什么';s是在多个线程共享的对象中实现唯一性的最佳方法
本文关键字:对象 共享 实现 方法 最佳 唯一性 线程 什么 | 更新日期: 2023-09-27 18:21:39
我感兴趣的是对数据库和其他函数的函数调用定时,以构建应用程序性能的一些指标。我使用了Stopwatch和一个metrics对象,但它似乎不能始终如一地给出正确的值。有时,调用一个函数所花费的时间与所有调用完全相同,这是不现实的。。。
我发现问题的原因是Metrics对象属性值。当其他线程生成的Metrics的其他实例被赋值时,一个Metrics对象的值会被覆盖。虽然每个线程都创建了一个新实例,但属性值似乎是每个引用的。
在多个线程共享的对象中实现唯一性的最佳方法是什么?
以下代码:
private Metrics Metrics;
private Stopwatch Stopwatch;
private int DegreeOfParallelism { get { return Convert.ToInt32(ConfigurationManager.AppSettings["DegreeOfParallelism"].ToString()); } }
var lOptions = new ParallelOptions() { MaxDegreeOfParallelism = DegreeOfParallelism };
Parallel.ForEach(RequestBag, lOptions, (lItem, loopState) =>
{
if (!string.IsNullOrEmpty(lItem.XmlRequest))
{
try
{
Metrics = new Metrics();
Stopwatch = new Stopwatch();
Stopwatch.Start();
ObjRef = new Object();
lItem.XmlRequest = ObjRef.GetDecision(Username, Password);
Stopwatch.Stop();
Metrics.ElapsedTime = string.Format("{0:0.00}", Stopwatch.Elapsed.TotalSeconds);
Stopwatch.Restart();
if (!string.IsNullOrEmpty(DBConnectionString))
{
DataAccess = new DataAccess2(DBConnectionString);
DataAccess.WriteToDB(lItem.XmlRequest);
}
Stopwatch.Stop();
Metrics.DbFuncCallTime = string.Format("{0:0.00}", Stopwatch.Elapsed.TotalSeconds);
}
catch (Exception pEx)
{
KeepLog(pEx);
Metrics.HasFailed = true;
}
finally
{
ProcessedIdsBag.Add(lItem.OrderId);
Metrics.ProcessedOrderId = lItem.OrderId;
Metrics.DegreeOfParallelism = DegreeOfParallelism;
Metrics.TotalNumOfOrders = NumberOfOrders;
Metrics.TotalNumOfOrdersProcessed = ProcessedIdsBag.Count;
pBackgroundWorker.ReportProgress(Metrics.GetProgressPercentage(NumberOfOrders, ProcessedIdsBag.Count), Metrics);
RequestBag.TryTake(out lItem);
}
}
});
任何帮助都将不胜感激。谢谢R
您想要做的似乎是为每个迭代创建一个度量对象,然后在最后聚合它们:
private ConcurrentBag<Metrics> allMetrics = new ConcurrentBag<Metrics>();
private int DegreeOfParallelism { get { return Convert.ToInt32(ConfigurationManager.AppSettings["DegreeOfParallelism"].ToString()); } }
var lOptions = new ParallelOptions() { MaxDegreeOfParallelism = DegreeOfParallelism };
Parallel.ForEach(RequestBag, lOptions, (lItem, loopState) =>
{
if (!string.IsNullOrEmpty(lItem.XmlRequest))
{
try
{
var Metrics = new Metrics();
var Stopwatch = new Stopwatch();
Stopwatch.Start();
ObjRef = new Object();
lItem.XmlRequest = ObjRef.GetDecision(Username, Password);
Stopwatch.Stop();
Metrics.ElapsedTime = string.Format("{0:0.00}", Stopwatch.Elapsed.TotalSeconds);
Stopwatch.Restart();
if (!string.IsNullOrEmpty(DBConnectionString))
{
DataAccess = new DataAccess2(DBConnectionString);
DataAccess.WriteToDB(lItem.XmlRequest);
}
Stopwatch.Stop();
Metrics.DbFuncCallTime = string.Format("{0:0.00}", Stopwatch.Elapsed.TotalSeconds);
}
catch (Exception pEx)
{
KeepLog(pEx);
Metrics.HasFailed = true;
}
finally
{
ProcessedIdsBag.Add(lItem.OrderId);
Metrics.ProcessedOrderId = lItem.OrderId;
Metrics.DegreeOfParallelism = DegreeOfParallelism;
Metrics.TotalNumOfOrders = NumberOfOrders;
Metrics.TotalNumOfOrdersProcessed = ProcessedIdsBag.Count;
pBackgroundWorker.ReportProgress(Metrics.GetProgressPercentage(NumberOfOrders, ProcessedIdsBag.Count), Metrics);
RequestBag.TryTake(out lItem);
allMetrics.add(Metrics);
}
}
});
// Aggregate everything in AllMetrics here
您需要更改Stopwatch和Metrics变量的范围。
目前,每个线程共享相同的Metrics变量。一旦线程进入try块,它就会创建一个Metrics的新实例(正确地),但会将其设置为共享变量(错误地)。所有其他线程在读取共享变量时都会看到该新实例,直到下一个线程出现并重新启动整个过程。
移动
private Metrics Metrics;
private Stopwatch Stopwatch;
就在你的循环内
Parallel.ForEach(RequestBag, lOptions, (lItem, loopState) =>
{
private Metrics Metrics;
private Stopwatch Stopwatch;
...
这将为循环中的每个迭代提供它自己的变量,在其中存储它自己的对象实例。