这是不是比锐化机器人更锋利
本文关键字:机器人 锐化 是不是 | 更新日期: 2023-09-27 18:36:54
Resharper更改了(当然,在我同意的情况下)这个:
private static Subdepartment GetSubdepartmentForXMLElement(XElement subdept)
{
return new Subdepartment
{
Id = Convert.ToInt32(subdept.Element("Id")),
AccountId = Convert.ToDouble(subdept.Element("AccountId ")),
Name = subdept.Element("Name")
};
}
。进入这个:
private static Subdepartment GetSubdepartmentForXMLElement(XElement subdept)
{
var xElement = subdept.Element("Id");
if (xElement != null)
{
var element = subdept.Element("AccountId");
if (element != null)
{
var el = subdept.Element("Name");
if (el != null)
{
return new Subdepartment
{
Id = Convert.ToInt32(xElement.Value),
AccountId = Convert.ToDouble(element.Value),
Name = el.Value
};
}
}
}
}
。我必须补充:
return null;
。在倒数第二个大括号之后,以允许它编译。
我喜欢 R#,但上面的代码对我来说看起来比一袋屁股丑 9 倍;这不是更好的锐化吗:
private static Subdepartment GetSubdepartmentForXMLElement(XElement subdept)
{
var IdElement = subdept.Element("Id");
var AccountIdElement = subdept.Element("AccountId");
var NameElement = subdept.Element("Name");
if ((IdElement != null) && (AccountIdElement != null) && (NameElement != null))
{
return new Subdepartment
{
Id = Convert.ToInt32(IdElement.Value),
AccountId = Convert.ToDouble(AccountIdElement.Value),
Name = NameElement.Value
};
}
return null;
}
?
更新
出于某种原因,我实际上更喜欢这种"风格":
var IdElement = itemGroup.Element("Id");
var item_group_idElement = itemGroup.Element("item_group_id");
var nameElement = itemGroup.Element("name");
if ((null == IdElement) || (null == item_group_idElement) || (null == nameElement)) return null;
return new ItemGroup
{
Id = Convert.ToInt32(itemGroup.Element("Id").Value),
item_group_id = itemGroup.Element("item_group_id").Value,
name = itemGroup.Element("name").Value
};
这个:
private static Subdepartment GetSubdepartmentForXMLElement(XElement subdept)
{
return new Subdepartment
{
Id = Convert.ToInt32(xElement.Value),
AccountId = Convert.ToDouble(element.Value),
Name = el.Value
};
}
。甚至不编译。 xElement
、element
和 el
没有声明。
但是,锐化器不应该抱怨这一点:
private static Subdepartment GetSubdepartmentForXmlElement(XElement subdept)
{
if (subdept == null) throw new ArgumentNullException("subdept");
var idElement = subdept.Element("Id");
var accountIdElement = subdept.Element("AccountId");
var nameElement = subdept.Element("Name");
if (idElement != null && accountIdElement != null && nameElement != null)
{
return new Subdepartment
{
Id = Convert.ToInt32(idElement.Value),
AccountId = Convert.ToDouble(accountIdElement.Value),
Name = nameElement.Value
};
}
return null;
}
Resharper 代码更正一次仅适用于一个问题,这就是为什么您最终会在 OP 中出现嵌套混乱的原因。如果从一开始就仔细编写代码,则需要执行较少的这些单问题修复。
就个人而言,我更喜欢减少嵌套,并希望这样做更好一点:
private static Subdepartment GetSubdepartmentForXmlElement(XElement subdept)
{
if (subdept == null) throw new ArgumentNullException("subdept");
var idElement = subdept.Element("Id");
var accountIdElement = subdept.Element("AccountId");
var nameElement = subdept.Element("Name");
if (idElement == null || accountIdElement == null || nameElement == null)
return null;
return new Subdepartment
{
Id = Convert.ToInt32(idElement.Value),
AccountId = Convert.ToDouble(accountIdElement.Value),
Name = nameElement.Value
};
}
ReSharper也不会抱怨这一点。